conditionInverter = $conditionInverter;
$this->betterNodeFinder = $betterNodeFinder;
$this->stmtsManipulator = $stmtsManipulator;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Remove if, foreach and for that does not do anything', [new CodeSample(<<<'CODE_SAMPLE'
class SomeClass
{
public function run($value)
{
if ($value) {
}
foreach ($values as $value) {
}
return $value;
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class SomeClass
{
public function run($value)
{
return $value;
}
}
CODE_SAMPLE
)]);
}
/**
* @return array>
*/
public function getNodeTypes() : array
{
return [StmtsAwareInterface::class];
}
/**
* @param StmtsAwareInterface $node
* @return \PhpParser\Node|null|int
*/
public function refactor(Node $node)
{
if ($node->stmts === null) {
return null;
}
$this->hasChanged = \false;
foreach ($node->stmts as $key => $stmt) {
if (!$stmt instanceof If_ && !$stmt instanceof For_ && !$stmt instanceof Foreach_) {
continue;
}
if ($stmt->stmts !== []) {
continue;
}
if ($stmt instanceof If_) {
$this->processIf($stmt, $key, $node);
continue;
}
$this->processForForeach($stmt, $key, $node);
}
if ($this->hasChanged) {
return $node;
}
return null;
}
private function processIf(If_ $if, int $key, StmtsAwareInterface $stmtsAware) : void
{
if ($if->elseifs !== []) {
return;
}
// useless if ()
if (!$if->else instanceof Else_) {
if ($this->hasNodeSideEffect($if->cond)) {
return;
}
unset($stmtsAware->stmts[$key]);
$this->hasChanged = \true;
return;
}
$if->cond = $this->conditionInverter->createInvertedCondition($if->cond);
$if->stmts = $if->else->stmts;
$if->else = null;
$this->hasChanged = \true;
}
/**
* @param \PhpParser\Node\Stmt\For_|\PhpParser\Node\Stmt\Foreach_ $for
*/
private function processForForeach($for, int $key, StmtsAwareInterface $stmtsAware) : void
{
$stmts = (array) $stmtsAware->stmts;
if ($for instanceof For_) {
$variables = $this->betterNodeFinder->findInstanceOf(\array_merge($for->init, $for->cond, $for->loop), Variable::class);
foreach ($variables as $variable) {
if ($this->stmtsManipulator->isVariableUsedInNextStmt($stmts, $key + 1, (string) $this->getName($variable))) {
return;
}
}
unset($stmtsAware->stmts[$key]);
$this->hasChanged = \true;
return;
}
$exprs = \array_filter([$for->expr, $for->valueVar, $for->valueVar]);
$variables = $this->betterNodeFinder->findInstanceOf($exprs, Variable::class);
foreach ($variables as $variable) {
if ($this->stmtsManipulator->isVariableUsedInNextStmt($stmts, $key + 1, (string) $this->getName($variable))) {
return;
}
}
unset($stmtsAware->stmts[$key]);
$this->hasChanged = \true;
}
private function hasNodeSideEffect(Expr $expr) : bool
{
return $this->betterNodeFinder->hasInstancesOf($expr, [CallLike::class, Assign::class]);
}
}