valueResolver = $valueResolver;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Change array_key_exists() ternary to coalescing', [new CodeSample(<<<'CODE_SAMPLE'
class SomeClass
{
public function run($values, $keyToMatch)
{
$result = array_key_exists($keyToMatch, $values) ? $values[$keyToMatch] : null;
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class SomeClass
{
public function run($values, $keyToMatch)
{
$result = $values[$keyToMatch] ?? null;
}
}
CODE_SAMPLE
)]);
}
/**
* @return array>
*/
public function getNodeTypes() : array
{
return [Ternary::class];
}
/**
* @param Ternary $node
*/
public function refactor(Node $node) : ?Node
{
if (!$node->cond instanceof FuncCall) {
return null;
}
if (!$this->isName($node->cond, 'array_key_exists')) {
return null;
}
if (!$node->if instanceof ArrayDimFetch) {
return null;
}
if (!$this->areArrayKeysExistsArgsMatchingDimFetch($node->cond, $node->if)) {
return null;
}
if (!$this->valueResolver->isNull($node->else)) {
return null;
}
return new Coalesce($node->if, $node->else);
}
/**
* Equals if:
*
* array_key_exists($key, $values);
* =
* $values[$key]
*/
private function areArrayKeysExistsArgsMatchingDimFetch(FuncCall $funcCall, ArrayDimFetch $arrayDimFetch) : bool
{
$firstArg = $funcCall->args[0];
if (!$firstArg instanceof Arg) {
return \false;
}
$keyExpr = $firstArg->value;
$secondArg = $funcCall->args[1];
if (!$secondArg instanceof Arg) {
return \false;
}
$valuesExpr = $secondArg->value;
if (!$this->nodeComparator->areNodesEqual($arrayDimFetch->var, $valuesExpr)) {
return \false;
}
return $this->nodeComparator->areNodesEqual($arrayDimFetch->dim, $keyExpr);
}
}