ifManipulator = $ifManipulator;
$this->valueResolver = $valueResolver;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Changes redundant null check to instant return', [new CodeSample(<<<'CODE_SAMPLE'
$newNode = 'something';
if ($newNode !== null) {
return $newNode;
}
return null;
CODE_SAMPLE
, <<<'CODE_SAMPLE'
$newNode = 'something';
return $newNode;
CODE_SAMPLE
)]);
}
/**
* @return array>
*/
public function getNodeTypes() : array
{
return [StmtsAwareInterface::class];
}
/**
* @param StmtsAwareInterface $node
*/
public function refactor(Node $node) : ?StmtsAwareInterface
{
foreach ((array) $node->stmts as $key => $stmt) {
if (!$stmt instanceof If_) {
continue;
}
if ($stmt->else instanceof Else_) {
continue;
}
if ($stmt->elseifs !== []) {
continue;
}
if (!isset($node->stmts[$key + 1])) {
return null;
}
$nextNode = $node->stmts[$key + 1];
if (!$nextNode instanceof Return_) {
continue;
}
$expr = $this->ifManipulator->matchIfNotNullReturnValue($stmt);
if (!$expr instanceof Expr) {
continue;
}
$insideIfNode = $stmt->stmts[0];
if (!$nextNode->expr instanceof Expr) {
continue;
}
if (!$this->valueResolver->isNull($nextNode->expr)) {
continue;
}
unset($node->stmts[$key]);
$node->stmts[$key + 1] = $insideIfNode;
return $node;
}
return null;
}
}